Feat Multisig (threshold, signers counts) discrepancy checker from Notion #150
+928
−178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor the previous Multisig component that was out of date to include a discrepancy checker from Notion.
This will cover the following feature for each feature I have added the Prometheus metrics accordingly.
1.Discrepancy Checker
2.Notion Database
To fetch the value in Notion, this will fetch them using the token and the database ID.
both can be passed using the new introduced flags:
--notion.database.idand--notion.token.3.Webhooks support
Using the flag
--webhook.urlthis will display the alert in the webhooks url specified, see below for discord for example:4.High Value Threshold
This is an amount checker of the safe to make sure that the total value of safe is under a threshold or should be marked as
CRITICAL. (Example: if a safe as 800K$ in ETH but the price of ETH is increasing and the safe reach 1M$ then we need to categorize this safe as critical).To do this I have introduce the flag
--high.value.threshold.usdthat by default is set to 1M$.5. README & Instructions
The readme with the features + instructions for executing the monitor of the multisig registry monitor.
https://github.com/ethereum-optimism/monitorism/blob/57350e6dd773d79ecb9aa3be2dbf57bebcc16aa4/op-monitorism/multisig/README.md