feat: withdrawal monitor v2 #151
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated and simplified version of the withdrawal monitor.
Ethnical
reviewed
Aug 18, 2025
Ethnical
reviewed
Aug 18, 2025
Ethnical
reviewed
Aug 18, 2025
Ethnical
requested changes
Aug 19, 2025
There was a problem hiding this comment.
Looks pretty cool!
Before merging I think we should address the readme + few nits.
For each new monitoring component would be nice to have a robust README that show the Args, instructions etc
like this -> https://github.com/ethereum-optimism/monitorism/blob/main/op-monitorism/global_events/README.md
Ethnical
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated and simplified version of the withdrawal monitor.
Description
This PR introduces withdrawal monitor v2, a proposed replacement for the faultproof withdrawal monitor. This is a simplified version of the monitor that I've tried to make as reliable as possible without a lot of complex logic. It doesn't have the same node fallback system, but it should also be far more robust to errors in general. If nothing else, it should be much easier to maintain.
Tests
Added tests for the pure functions. We really need a framework to be able to test everything else, it's a bit of a nightmare right now to test anything in a production network, I didn't feel like building that framework here.