refactor: correcting the Merkle-Patricia Trie example #15325
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokerstudio
requested review from
corwintines,
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This issue is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
Status: Stale
wackerow
reviewed
Sep 18, 2025
There was a problem hiding this comment.
@jokerstudio Forgive me for not following the details of this change... #16048 recently updated the copy below to fix the issue you're describing.. could you help me understand the change to these hashC and hashD lines?
wackerow
removed
the
Status: Stale
|
This issue is stale because it has been open 30 days with no activity. |
github-actions
bot
added
the
Status: Stale
|
closing out for now but please feel free to re-open with further details, thanks! |
github-actions
bot
added
the
abandoned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For Merkle-Patricia Trie, when data does not exceed 32 bytes, it is stored in the node directly without hashing. This change fixes the example trie structure to align with this concept.