-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Optimize mobile nav #16111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize mobile nav #16111
Conversation
2c65e4a
to
ff72859
Compare
ff72859
to
7c0d78e
Compare
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dd4725d
to
ba34098
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great 🔥, well done @pettinarip! Will be curious to see the impact here
|
||
type ClientOnlyProps = { | ||
children: ReactNode | ||
fallback?: ReactNode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't block, but perhaps we rename this to loading
for consistency with other loading components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, but the intention of fallback
is that it can be anything (including null
). On the other hand, loading
narrows the scope, leading developers to think they should only use loading UIs, which isn’t correct.
92ffc7f
Description
languages
on the serverprogress
on the server