Skip to content

Conversation

pettinarip
Copy link
Member

@pettinarip pettinarip commented Aug 22, 2025

Description

  • nav — code refactors & reorganization
  • menu — ssr content
  • menu — replace accordions with collapsibles (collapsible is a primitive of the accordion component) to improve performance with nested trees
  • menu — remove Sheet overlay and hamburger animation to reduce main thread usage
  • language picker — pre-calculate languages on the server
  • language picker — pre-calculate progress on the server
  • language picker — open content inside the existing Sheet container instead of creating a new Dialog

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Aug 22, 2025
Base automatically changed from fix-nav-hydration to dev August 24, 2025 20:52
Copy link

netlify bot commented Aug 25, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 92ffc7f
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/68b8772a2edce60008ad0de4
😎 Deploy Preview https://deploy-preview-16111--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 42 (🔴 down 10 from production)
Accessibility: 96 (🟢 up 1 from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 100 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@pettinarip pettinarip changed the base branch from dev to staging August 28, 2025 13:28
@github-actions github-actions bot added the dependencies 📦 Changes related to project dependencies label Aug 28, 2025
@pettinarip pettinarip marked this pull request as ready for review August 29, 2025 13:25
@github-actions github-actions bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Sep 1, 2025
wackerow
wackerow previously approved these changes Sep 3, 2025
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great 🔥, well done @pettinarip! Will be curious to see the impact here


type ClientOnlyProps = {
children: ReactNode
fallback?: ReactNode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't block, but perhaps we rename this to loading for consistency with other loading components?

Copy link
Member Author

@pettinarip pettinarip Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, but the intention of fallback is that it can be anything (including null). On the other hand, loading narrows the scope, leading developers to think they should only use loading UIs, which isn’t correct.

corwintines
corwintines previously approved these changes Sep 3, 2025
@pettinarip pettinarip dismissed stale reviews from corwintines and wackerow via 92ffc7f September 3, 2025 17:13
@pettinarip pettinarip merged commit f085e00 into staging Sep 4, 2025
17 of 19 checks passed
@pettinarip pettinarip deleted the optimize-nav branch September 4, 2025 09:03
@pettinarip pettinarip mentioned this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants