Skip to content

feat(tests): tests for ecrecover precompile #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2025
Merged

feat(tests): tests for ecrecover precompile #1685

merged 1 commit into from
Oct 31, 2025

Conversation

@pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Oct 27, 2025 •
edited by spencer-tb
Loading

🗒️ Description

Adds missing coverage for the ecrecover precompile. Sourced from evmone unit tests.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks: 
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@pdobacz pdobacz changed the title fest(tests): tests for ecrecover precompile feat(tests): tests for ecrecover precompile Oct 27, 2025
@pdobacz pdobacz force-pushed the tests/ecrecover branch 2 times, most recently from 9fbb29b to bc6fb26 Compare October 27, 2025 09:47
spencer-tb added a commit to spencer-tb/execution-specs that referenced this pull request Oct 27, 2025
@spencer-tb
feat(tests): EIP-7918 - Blob base fee bounded by execution cost (ethe…
e23d3e7 
…reum#1685)

* feat(forks|tests): eip-7918 initial tests plus eip-4844 adjustments.

* chore(tests): extra param and docstring tweak.
@pdobacz pdobacz force-pushed the tests/ecrecover branch 2 times, most recently from e6386ed to 3f97855 Compare October 27, 2025 10:43
spencer-tb
spencer-tb reviewed Oct 29, 2025
View reviewed changes
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the default.profraw file?

@spencer-tb spencer-tb added C-enhance Category: an improvement or new feature A-test-tests Area: tests for execution spec tests labels Oct 29, 2025
@pdobacz
feat(tests): tests for ecrecover precompile
f80380e 
sourced from `evmone` unit tests
@pdobacz
Copy link
Contributor Author

pdobacz commented Oct 29, 2025

Can we remove the default.profraw file?

Whoopsie, git fail, fixed

@pdobacz pdobacz requested a review from spencer-tb October 31, 2025 08:20
spencer-tb
spencer-tb approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! LGTM!

@spencer-tb spencer-tb merged commit 60a4cf2 into ethereum:forks/osaka Oct 31, 2025
8 of 9 checks passed
@pdobacz pdobacz deleted the tests/ecrecover branch October 31, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spencer-tb spencer-tb spencer-tb approved these changes

Assignees

No one assigned

Labels

A-test-tests Area: tests for execution spec tests C-enhance Category: an improvement or new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pdobacz @spencer-tb