params: Config2 #32224
Draft
params: Config2 #32224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not great to call scheduleAtTime so many times. The function is much more expensive now since it has to establish the fork order every time. A later refactoring needs to turn it around to compute the order only once.
lightclient
reviewed
Aug 11, 2025
|
|
||
| var ConfigParam = params.Define(params.T[Config]{ | ||
| Name: "clique", | ||
| Optional: true, // optional says |
There was a problem hiding this comment.
missing part of the comment here?
| param map[int]any | ||
| } | ||
|
|
||
| func NewConfig2(activations Activations, param ...ParamValue) *Config2 { |
| return ok | ||
| } | ||
|
|
||
| // SetActivations returns a new configuration with the given forks activated. |
There was a problem hiding this comment.
Suggested change
| // SetActivations returns a new configuration with the given forks activated. | |
| // SetActivations returns a new configuration with the given forks activations. |
I think it should say "activations" since the way it currently reads is that that it will make the new config have the passed in forks be active.
There was a problem hiding this comment.
This method is a little confusing to me in general though, it seems like it should set the forks for the current Config2 object (even overwriting the existing) but instead it returns a new object that has both the existing activations and the new activations.
Comment on lines
+28
to
+33
| func (cfg *Config2) Rules(blockNum uint64, blockTime uint64) Rules2 { | ||
| r := Rules2{ | ||
| active: make(map[forks.Fork]bool, len(cfg.activation)), | ||
| } | ||
| return r | ||
| } |
There was a problem hiding this comment.
Seems like this still needs to fill in the active map?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring of the fork configuration system. The design goals for this change are as follows:
Forks
to make this simpler, so that ideally a new enum value has to be added and that's it.
Parameters
handled by a global registry, and can be implemented across different packages. For example, the EIP-1559 configuration can be implemented in the eip1559 package, where the config is ultimately used.
Config/Rules object
map[Fork]bool.