Set default 30s timeout for HTTP RPC client to prevent indefinite hangs #32565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a safe default timeout to the HTTP RPC client to avoid requests hanging indefinitely when no context deadline is provided.
Changes
rpc/http.go
:DialHTTP
now uses&http.Client{Timeout: 30 * time.Second}
.newClientTransportHTTP
initializeshttp.Client
withTimeout: 30 * time.Second
.Rationale
http.Client
without a timeout is a known anti-pattern and can lead to resource exhaustion/DoS if servers keep connections open without responding.Backward Compatibility
WithHTTPClient
orDialHTTPWithClient
are respected and unchanged.