fix: discovery AyncFilter deadlock on shutdown #32572
Open
+9
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi, we found a occasionally node hang issue on BSC, I think Geth may also have the issue, so pick the fix patch here.
The fix on BSC repo: bnb-chain/bsc#3347
When the hang occurs, there are two routines stuck.
On node start, it will run part of the DiscoveryV4 protocol, which could take considerable time, here is its hang callstack:
It is the main routine to shutdown the process, but it got stuck when it tries to shutdown the discovery components, as it tries to drain the channel of
<-f.slots
, but the extra 1 slot will never have chance to be resumed.The rootcause of the hang is caused by the extra 1 slot, which was designed to make sure the routines in
AsyncFilter(...)
can be finished. This PR fixes it by making sure the extra 1 shot can always be resumed when node shutdown.