core, eth: add lock protection in snap sync #33428
Merged
+149
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
requested review from
MariusVanDerWijden,
fjl,
jwasinger and
lightclient
as code owners
eth/catalyst/metrics.go
Outdated
| @@ -0,0 +1,33 @@ | |||
| // Copyright 20222 The go-ethereum Authors | |||
Member
There was a problem hiding this comment.
Wow you're living in the future 😋
MariusVanDerWijden
previously approved these changes
Dec 18, 2025
Member
MariusVanDerWijden
left a comment
MariusVanDerWijden
left a comment
There was a problem hiding this comment.
LGTM, I have not tested it though
Member
Author
|
@MariusVanDerWijden Can I get another approval? |
MariusVanDerWijden
approved these changes
Dec 19, 2025
4 tasks
This was referenced Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33396, #33397, #33398