-
-
Notifications
You must be signed in to change notification settings - Fork 339
Add context local resource #931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
elina-israyelyan
wants to merge
11
commits into
ets-labs:develop
Choose a base branch
from
elina-israyelyan:add-context-local-resource
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add context local resource #931
elina-israyelyan
wants to merge
11
commits into
ets-labs:develop
from
elina-israyelyan:add-context-local-resource
+776
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
281cb2f to
bc7b4eb
Compare
ZipFile
requested changes
Nov 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Thanks for contribution. Idea is good, but there are some code duplication issues needs to be addressed before we can merge it. Also, it would be really nice to have documentation updated with usage examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue #728 , #760
Relates to #699
Added a
ContextLocalResourceclass that inherits fromResourceand overrides it so that the actual_resourceand_shutdownerare stored and retrieved viaContextVar.This allows each context (such as a FastAPI request) to have its own instance of the resource.
Since FastAPI creates a new context per request, each request now gets its own context-scoped resource.
Because the class extends
Resource, theClosingmarker continues to work as expected.Demo
Run the following API, then do concurrent requests.