remove checkFramebufferStatus call in texture.js drawTo
#59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Axel-Jacobsen
force-pushed
the
master
branch
from
ae8144f to
23bc248
Compare
Axel-Jacobsen
changed the title
checkFramebufferStatus call in texture.js drawTo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy!
The function call of
checkFramebufferStatusintexture.jstakes about 37% ofdrawTocalls on Chrome, by my profiling:with_checkFrameBufferStatus.json.zip
On analysis, when
checkFramebufferStatusreturns with something other thanFRAMEBUFFER_COMPLETE, an error is thrown.If an error is not manually thrown, an error would still pop-up no? If the if-statement is removed, the only thing lost is a bit of clarity (occasionally, I haven't ever bumped into this issue) for a 40% gain of efficiency.
Simply removing this if-statement speeds things up:
without_getFramebufferStatus.json.zip
Perhaps I am missing something that
checkFramebufferStatusdoes, and if this is the case please let me know!Cheers, I adore glfx.js!