Skip to content

Strict value is not null coalesced from a false value #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Strict value is not null coalesced from a false value #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/messaging/handle.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,9 @@ def message_registry
end
end

## Can't null-coalesce here. It's a boolean. Use expanded form of `if` block - Scott, Mon Oct 16 2023
def strict
@strict ||= Defaults.strict
@strict = Defaults.strict if @strict.nil?
@strict
end
alias :strict? :strict

Expand All @@ -174,7 +174,7 @@ def call(message_or_message_data, strict: nil)
end

def handle_message(message, strict: nil)
strict ||= self.strict?
strict = self.strict? if strict.nil?

handler_logger.trace(tags: [:dispatch, :message]) { "Dispatching message (Message class: #{message.class.name})" }
handler_logger.trace(tags: [:data, :message]) { message.pretty_inspect }
Expand Down Expand Up @@ -202,7 +202,7 @@ def handle_message(message, strict: nil)
end

def handle_message_data(message_data, strict: nil)
strict ||= self.strict?
strict = self.strict? if strict.nil?

handler_logger.trace(tags: [:dispatch, :message_data]) { "Dispatching message data (Type: #{message_data.type})" }
handler_logger.trace(tags: [:data, :message_data]) { message_data.pretty_inspect }
Expand Down