Skip to content

Conversation

oysandvik94
Copy link

Avoid security risk of using snapshot version, and instead pin to latest sha commit.

action.yaml Outdated

- name: Set up Maven
uses: stCarolas/setup-maven@v5
uses: stCarolas/setup-maven@d6af6abeda15e98926a57b5aa970a96bb37f97d1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think common practice is to put the version that's being pinned as a comment in the same line so that people know which version the hash is referring to. Could you do that here and for the action above it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Also realized I should use release version, not latest commit

@oysandvik94
Copy link
Author

@mkekeberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants