Skip to content

Fallback to uri if alt text is empty in inline image #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fallback to uri if alt text is empty in inline image #1035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion myst_parser/mdit_to_docutils/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1175,7 +1175,7 @@ def render_image(self, token: SyntaxTreeNode) -> None:

img_node["uri"] = destination

img_node["alt"] = self.renderInlineAsText(token.children or [])
img_node["alt"] = self.renderInlineAsText(token.children or []) or destination

self.copy_attributes(
token,
Expand Down
9 changes: 9 additions & 0 deletions tests/test_renderers/fixtures/docutil_syntax_elements.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,15 @@ Image empty:
<image alt="" uri="">
.

Image without alt:
.
![](src)
.
<document source="notset">
<paragraph>
<image alt="src" uri="src">
.

Image with alt and title:
.
![alt](src "title")
Expand Down
9 changes: 9 additions & 0 deletions tests/test_renderers/fixtures/sphinx_syntax_elements.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,15 @@ Image empty:
<image alt="" uri="">
.

Image without alt:
.
![](src)
.
<document source="<src>/index.md">
<paragraph>
<image alt="src" uri="src">
.

Image with alt and title:
.
![alt](src "title")
Expand Down