Skip to content

Conversation

dsletten
Copy link

@dsletten dsletten commented Jul 2, 2022

No description provided.

@github-actions github-actions bot added track/java Java track type/mentor-notes Mentor notes labels Jul 2, 2022
@SleeplessByte
Copy link
Member

@exercism/java please check!

@SleeplessByte SleeplessByte changed the title Create mentoring.md [java/rational-numbers] Create mentoring.md Feb 16, 2024
@sanderploegsma
Copy link
Contributor

This is good feedback, but is actually a bug in the exercise itself. I checked the reference implementation and it turns out it uses a completely different implementation compared to the exercise instructions.

@dsletten would you be willing to submit a PR to https://github.com/exercism/java to address this? I think the reference implementation should be updated to use

Math.pow(Math.pow(base, numerator), 1.0/denominator);

And the tolerance in the tests should be lowered to the point where this implementation passes the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

track/java Java track type/mentor-notes Mentor notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants