feat: don't switch zone for dns command #750
Open
+10
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The DNS command are not zone dependent, so this MR remove the need to change the zone for DNS command.
The reason behind that: I created a role for DNS challenge for getting web certificate.
I wanted to test if my role allows only the TXT records that I wanted. The easiest was to test with the exo cli.
However, due to the
SwitchClientZoneV3, the role need also the permissioncompute.list-zones(or something similar), if I want to edit DNS Records with the exo cli, which is not needed for the tools like lego or cert-manager.From what I understood, the client will be created within the
buildClient. Let me know if I missed something.Checklist
(For exoscale contributors)
Testing
Create, delete, update DNS records work.