Fix *vm.VM memory leak #813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's reslicing using
[0:0]
(which is equivalent to[:0]
), but this does not clear the memory references in the underlying array, which prevents garbage collection. For instance, if:Then the Nth old item will not be garbage collected because there is still a reference to it in the underlying array.
So we need to "clear the tail" of the slice before reslicing to avoid this. See these example issues: