Fix error position reporting in multiline script #827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreev-fn
force-pushed
the
fix-error-position-in-multiline-script
branch
from
ab5a103 to
1f55c23
Compare
andreev-fn
force-pushed
the
fix-error-position-in-multiline-script
branch
from
1f55c23 to
e47bbb4
Compare
antonmedv
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #826
Description of changes:
The problem was that lineStart was set not after the '\n' character, but directly on it, which caused lineStart to always equal lineEnd.
In addition, there was a second minor issue — the '\n' character was being counted in the column counter, which made the counter always show 1 more than it should.