Skip to content

Conversation

sanajitjana
Copy link

Description

issue #2056

This is my first contribution to the project.
I’ve made the necessary changes/fixes as per the issue.
Please review and let me know if any improvements are needed.

Developer's Certificate of Origin

By making this contribution, I certify that:

  • The work is my own or based on appropriately licensed work.
  • I have the right to submit it under the project’s open source license.
  • I agree that this contribution is public and may be redistributed under the same license.

Signed-off-by: Sanajit Jana [email protected]

@sanajitjana sanajitjana requested a review from a team as a code owner September 10, 2025 10:59
Copy link

netlify bot commented Sep 10, 2025

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit a2a4217
🔍 Latest deploy log https://app.netlify.com/projects/expressjscom-preview/deploys/68c559160af9ad00087827fc
😎 Deploy Preview https://deploy-preview-2057--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@@ -44,4 +44,6 @@ $ node app.js

Laden Sie dann [http://localhost:3000/](http://localhost:3000/) in einen Browser, um die Ausgabe zu sehen.

### [Previous: Installing ](/{{ page.lang }}/starter/installing.html)    [Next: Express Generator ](/{{ page.lang }}/starter/generator.html)
Copy link
Member

@ShubhamOulkar ShubhamOulkar Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove changes from this file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not resolved

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below code was my changes and now, already reverted my changes to previous state.

Image

or should I entirely remove this L47 line?

@sanajitjana
Copy link
Author

hi @ShubhamOulkar, incorporated all the above feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants