Skip to content

Solve all the type issues #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Solve all the type issues #120

wants to merge 5 commits into from

Conversation

eyeseast
Copy link
Owner

@eyeseast eyeseast commented Jun 2, 2025

Closes #116
Closes #112
Closes #121

Much more type checking, trying to be strict about things. Ultimately lots of changes that should amount to no actual change in functionality.

@eyeseast
Copy link
Owner Author

eyeseast commented Jun 2, 2025

This is passing everywhere except Python 3.9, which hits end-of-life in October. The issue is typing.TypeGuard, which was added in 3.10. Three options, then:

  • Drop 3.9 early
  • Wait to release this until October
  • Type check without using TypeGuard

@liffiton
Copy link

liffiton commented Jun 6, 2025

If you're taking votes, I'd vote for dropping 3.9 early. Folks on 3.9 can keep using the existing release.

It would be tricky if you wanted to keep supporting 3.9 with other updates, but this is a simple, stable library that doesn't need frequent updates.

@eyeseast
Copy link
Owner Author

eyeseast commented Jun 6, 2025

I might make a 2.0 branch that I can merge this into, and work on all the other overdue updates, with a plan to release that all at once in October when 3.9 goes off to the land of unsupported software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop 3.8, add 3.13 Allow pathlib in types Version 1.1.0 is missing the py.typed marker
2 participants