Add ersatz hh_fanout for OSS
#9671
Open
+77
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszabo-wikia
force-pushed
the
create-hh-fanout-replacement
branch
from
5ec50cd to
a00d0a0
Compare
Contributor
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
mszabo-wikia
force-pushed
the
create-hh-fanout-replacement
branch
from
a00d0a0 to
a31b6d9
Compare
Contributor
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
The `hh_fanout` binary was removed in D53956499, preventing OSS users from generating dependency graph files needed for loading saved states. Fortunately, the backing logic still exists in the repo and we can trivially create a Rust executable to expose it again. Do so, replacing some `panic`s in the backing code with `Err` returns for consistency.
mszabo-wikia
force-pushed
the
create-hh-fanout-replacement
branch
from
a31b6d9 to
4ec6fcf
Compare
Contributor
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hh_fanoutbinary was removed in D53956499, preventing OSS users from generating dependency graph files needed for loading saved states.Fortunately, the backing logic still exists in the repo and we can trivially create a Rust executable to expose it again. Do so, replacing some
panics in the backing code withErrreturns for consistency.