Skip to content

Fix CQS signal readability-avoid-const-params-in-decls in xplat/js/react-native-github/packages #53882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −24
Open

Fix CQS signal readability-avoid-const-params-in-decls in xplat/js/react-native-github/packages #53882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/React/CoreModules/RCTAppearance.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#import <React/RCTEventEmitter.h>

RCT_EXTERN void RCTEnableAppearancePreference(BOOL enabled);
RCT_EXTERN void RCTOverrideAppearancePreference(NSString *const);
RCT_EXTERN void RCTOverrideAppearancePreference(NSString *);
RCT_EXTERN void RCTUseKeyWindowForSystemStyle(BOOL useMainScreen);
RCT_EXTERN NSString *RCTCurrentOverrideAppearancePreference(void);
RCT_EXTERN NSString *RCTColorSchemePreference(UITraitCollection *traitCollection);
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/React/Views/RCTBorderDrawing.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ RCT_EXTERN CGPathRef RCTPathCreateWithRoundedRect(
CGRect bounds,
RCTCornerInsets cornerInsets,
const CGAffineTransform *transform,
const BOOL inverted);
BOOL inverted);

/**
* Draw a CSS-compliant border as an image. You can determine if it's scalable
Expand Down
14 changes: 6 additions & 8 deletions packages/react-native/ReactAndroid/src/main/jni/react/jni/JReactMarker.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,20 +24,18 @@ class JReactMarker : public facebook::jni::JavaClass<JReactMarker> {
private:
static void logMarker(const std::string& marker);
static void logMarker(const std::string& marker, const std::string& tag);
static void logMarker(
const std::string& marker,
const std::string& tag,
const int instanceKey);
static void
logMarker(const std::string& marker, const std::string& tag, int instanceKey);
static void logPerfMarker(
const ReactMarker::ReactMarkerId markerId,
ReactMarker::ReactMarkerId markerId,
const char* tag);
static void logPerfMarkerBridgeless(
const ReactMarker::ReactMarkerId markerId,
ReactMarker::ReactMarkerId markerId,
const char* tag);
static void logPerfMarkerWithInstanceKey(
const ReactMarker::ReactMarkerId markerId,
ReactMarker::ReactMarkerId markerId,
const char* tag,
const int instanceKey);
int instanceKey);
static void nativeLogMarker(
jni::alias_ref<jclass> /* unused */,
const std::string& markerNameStr,
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/cxxreact/JSExecutor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ class RN_EXPORT [[deprecated(
* necessary native modules methods.
*/
virtual void invokeCallback(
const double callbackId,
double callbackId,
const folly::dynamic& arguments) = 0;

virtual void setGlobalVariable(
Expand Down
8 changes: 4 additions & 4 deletions packages/react-native/ReactCommon/cxxreact/JSIndexedRAMBundle.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ class RN_EXPORT [[deprecated(
};

void init();
std::string getModuleCode(const uint32_t id) const;
void readBundle(char* buffer, const std::streamsize bytes) const;
std::string getModuleCode(uint32_t id) const;
void readBundle(char* buffer, std::streamsize bytes) const;
void readBundle(
char* buffer,
const std::streamsize bytes,
const std::istream::pos_type position) const;
std::streamsize bytes,
std::istream::pos_type position) const;

mutable std::unique_ptr<std::istream> m_bundle;
ModuleTable m_table;
Expand Down
14 changes: 6 additions & 8 deletions packages/react-native/ReactCommon/cxxreact/ReactMarker.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,13 @@ extern RN_EXPORT std::shared_mutex logTaggedMarkerImplMutex;
extern RN_EXPORT LogTaggedMarker logTaggedMarkerImpl;
extern RN_EXPORT LogTaggedMarker logTaggedMarkerBridgelessImpl;

extern RN_EXPORT void logMarker(const ReactMarkerId markerId); // Bridge only
extern RN_EXPORT void logMarker(ReactMarkerId markerId); // Bridge only
extern RN_EXPORT void logTaggedMarker(
const ReactMarkerId markerId,
ReactMarkerId markerId,
const char* tag); // Bridge only
extern RN_EXPORT void logMarkerBridgeless(const ReactMarkerId markerId);
extern RN_EXPORT void logMarkerBridgeless(ReactMarkerId markerId);
extern RN_EXPORT void logTaggedMarkerBridgeless(
const ReactMarkerId markerId,
ReactMarkerId markerId,
const char* tag);

struct ReactMarkerEvent {
Expand All @@ -76,7 +76,7 @@ class RN_EXPORT StartupLogger {
public:
static StartupLogger& getInstance();

void logStartupEvent(const ReactMarkerId markerId, double markerTime);
void logStartupEvent(ReactMarkerId markerId, double markerTime);
void reset();
double getAppStartupStartTime();
double getInitReactRuntimeStartTime();
Expand All @@ -101,8 +101,6 @@ class RN_EXPORT StartupLogger {
// When the marker got logged from the platform, it will notify here. This is
// used to collect react markers that are logged in the platform instead of in
// C++.
extern RN_EXPORT void logMarkerDone(
const ReactMarkerId markerId,
double markerTime);
extern RN_EXPORT void logMarkerDone(ReactMarkerId markerId, double markerTime);

} // namespace facebook::react::ReactMarker
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ class [[deprecated(
const std::string& moduleId,
const std::string& methodId,
const folly::dynamic& arguments) override;
void invokeCallback(const double callbackId, const folly::dynamic& arguments)
void invokeCallback(double callbackId, const folly::dynamic& arguments)
override;
void setGlobalVariable(
std::string propName,
Expand Down
Loading