Skip to content

Fix request permission is not always resolving in Android 16 #53898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix request permission is not always resolving in Android 16 #53898

wants to merge 2 commits into from

Conversation

lukmccall
Copy link
Contributor

Summary:

Fixes: #53887
Fixes: expo/expo#39480

In the latest Android 16 update, requesting permissions does not always change the app's state (the onPause and onResume functions aren't called). For instance, when you deny permission 3 times, the last promise won't resolve until you move the app to the background. The current logic inside the ReactActivityDelegate assumes that Android will call onResume after receiving permission state information from the system, which is no longer the case.

Probably connected with this commit

Changelog:

[ANDROID] [FIXED] - Fix request permission not always resolving in Android 16

Test Plan:

  • I've tested it in the RNTester by denying the camera permission three times.
  • I've also checked if the patch works with the Expo permissions code.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 23, 2025
@facebook-github-bot facebook-github-bot added p: Software Mansion Partner: Software Mansion Partner p: Expo Partner: Expo Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 23, 2025
@lukmccall lukmccall mentioned this pull request Sep 23, 2025
Open
@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D83059478.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Expo Partner: Expo p: Software Mansion Partner: Software Mansion Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
2 participants
@lukmccall @facebook-github-bot