Skip to content

Fix CQS signal readability-const-return-type in xplat/js/react-native-github/packages #53940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+3 −3
Closed

Fix CQS signal readability-const-return-type in xplat/js/react-native-github/packages #53940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpInteractionTypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const InteractionTypesMap& getInteractionTypes() {
return INTERACTION_TYPES;
}

const std::string_view getInteractionTypeForEvent(std::string_view eventName) {
std::string_view getInteractionTypeForEvent(std::string_view eventName) {
const auto& interactionTypes = getInteractionTypes();
auto it = interactionTypes.find(eventName);
if (it != interactionTypes.end()) {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpInteractionTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ using InteractionTypesMap =

const InteractionTypesMap& getInteractionTypes();

const std::string_view getInteractionTypeForEvent(std::string_view eventName);
std::string_view getInteractionTypeForEvent(std::string_view eventName);

} // namespace facebook::react
2 changes: 1 addition & 1 deletion ...nderer/components/legacyviewmanagerinterop/LegacyViewManagerInteropComponentDescriptor.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ static Class getViewManagerClass(const std::string &componentName, RCTBridge *br
return nil;
}

static const std::shared_ptr<void> constructCoordinator(
static std::shared_ptr<void> constructCoordinator(
const std::shared_ptr<const ContextContainer> &contextContainer,
const ComponentDescriptor::Flavor &flavor)
{
Expand Down
Loading