Skip to content

Update print-warnings.js #33945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update print-warnings.js #33945

wants to merge 1 commit into from

Conversation

Rsc2414
Copy link

@Rsc2414 Rsc2414 commented Jul 18, 2025

Summary
Added support to the warning collection script for extracting metadata like file and line number for each console.warn and console.error call. The script now outputs an array of structured objects with type, message, file, and line, allowing better traceability and auditing of warnings. Also added sorting by file and line number for consistent output.

How did you test this change?
Ran the script locally with:

bash
Copy
Edit
node scripts/collect-warnings.js > extractedWarnings.js
Manually verified output includes correct type, message, file, and line.

Checked against multiple sample files with console.warn/console.error to confirm correctness.

Ensured no breakage in existing behavior for messages that cannot be evaluated.

Confirmed consistent formatting and sorted order in the final output.

Copy link

meta-cla bot commented Jul 18, 2025

Hi @Rsc2414!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Jul 18, 2025
Copy link

meta-cla bot commented Jul 18, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant