Skip to content

Conversation

chirokas
Copy link

Summary

This adds support for the fullscreenchange and fullscreenerror events.

These events are currently supported in Chrome and Firefox(see browser compatibility table). You can read more about these events here.


case 'blur':
case 'fullscreenchange':
case 'focus':

I omit fullscreenerror here so it falls back to default below.

How did you test this change?

Added unit tests.

@meta-cla meta-cla bot added the CLA Signed label Sep 27, 2025
@chirokas chirokas marked this pull request as ready for review September 27, 2025 08:28
@react-sizebot
Copy link

react-sizebot commented Sep 28, 2025

Comparing: dce1f6c...fda4b13

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.01% 536.10 kB 536.16 kB +0.02% 94.79 kB 94.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 663.69 kB 663.75 kB +0.02% 117.00 kB 117.02 kB
facebook-www/ReactDOM-prod.classic.js = 687.59 kB 687.66 kB +0.01% 121.04 kB 121.06 kB
facebook-www/ReactDOM-prod.modern.js = 678.02 kB 678.08 kB +0.01% 119.39 kB 119.41 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against fda4b13

@eps1lon
Copy link
Collaborator

eps1lon commented Sep 28, 2025

I suspect fullscreenerror should also get discrete priority like fullscreenchange in

case 'fullscreenchange':
case 'focus':
case 'hashchange':
case 'popstate':
case 'select':
case 'selectstart':
return DiscreteEventPriority;
?

@chirokas
Copy link
Author

Agree this should be discrete. Just noticed that invalid was marked as discrete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants