Simplify release-from-npm workflow #34702
Draft
+76
−256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Runtime packages (packages in
~/packages) don't use the same SemVer version (e.g. eprh is on 6.2 while React&friends is on 19.2). However, they do use the same prerelease while their designated SemVer stable version is already known inReactVersions.js.The publish prelease from npm workflow now only accepts the prerelease you want to promote e.g. in 19.2.0-canary-abc-123 the prerelease is
abc-123. We always promote canaries now. That's a bit awkward if we want to promote from canary to alpha to beta to stable. Either we have to remember which Canary we promoted or we promote from the latest Canary which we've done for 19.0.Note that the designated version is the one the workflow is running on. So for backports you need to run the workflow from a backport branch.
This doesn't support promoting to another prerelease channel e.g. to beta. We'll add support from that when we're working on v20.