chore(fixtures): migrate attribute-behavior fixture to createRoot API #34716
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the fixtures folder to use the new createRoot API instead of the legacy ReactDOM.render.
The motivation is to align the test fixtures with the current recommended React API, ensuring consistency with React 18+.
How did you test this change?
Updated all fixture files to use createRoot.
Ran yarn test → all tests passed ✅.
Ran yarn test --prod to confirm behavior in production mode.
Manually tested the fixtures in local development to verify correct rendering.