fix(compiler): compiler workspaces setting #34799
Open
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'start' and 'next' scripts reference 'yarn workspace playground' but the playground app in apps/playground was not included in the workspaces configuration. This caused these commands to fail. Added 'apps/*' to the workspaces.packages array to properly register the playground workspace.
arthur-mountain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The 'start' and 'next' scripts in the compiler monorepo reference 'yarn workspace playground', but the playground app in compiler/apps/playground was not included in the workspaces configuration. This caused these commands to fail.
This PR adds 'apps/*' to the workspaces.packages array to properly register the playground workspace.
How did you test this change?
Verified by running 'yarn start' locally, and confirmed that the snapshot error shown above no longer appears.