@oneOf input objects stricter typegen #5108
Open
+565
−209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malien
changed the title
# Conflicts: # compiler/crates/relay-typegen/src/flow.rs
Author
|
I might want to run the whole rustfmt / fixture-gen to fix the formatting checks |
captbaritone
reviewed
Dec 2, 2025
captbaritone
reviewed
Dec 2, 2025
| ), | ||
| }) | ||
| }) | ||
| let node = if typegen_context.project_config.typegen_config.one_of_type |
Contributor
There was a problem hiding this comment.
Thanks for making this a config option!
captbaritone
reviewed
Dec 2, 2025
compiler/crates/relay-typegen/tests/generate_flow_with_custom_id_test.rs
Outdated
Show resolved
Hide resolved
captbaritone
reviewed
Dec 2, 2025
|
|
||
| impl Default for OneOfGeneration { | ||
| fn default() -> Self { | ||
| Self::Strict |
Contributor
There was a problem hiding this comment.
I like this default choice.
Author
|
@captbaritone I think we're gtg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am a man of my word: https://discord.com/channels/625400653321076807/862957601670430731/1438602698575577099
Makes so that
@oneOfinput types generate a more strict type union, that permits only a single property being set a a time. This is technically a breaking change, since people may have relied on a more permissive type in their application logic. So there is an escape hatch of aoneOfType: "relaxed". I'm not sure this is a necessary option to have. We might as well break a tiny (like real tiny) amount of people's types.Closes #5095