Skip to content

Conversation

luccabb
Copy link
Member

@luccabb luccabb commented Oct 4, 2025

Summary

Slurm tasks is a common denominator that also covers array use cases. So I'm removing slurm array methods from the CLI.

@luccabb luccabb requested review from skalyan and gunchu as code owners October 4, 2025 00:26
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 4, 2025
@luccabb luccabb changed the title remove array methods remove array from cli Oct 4, 2025
Copy link

@gunchu gunchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!



@job_gen.command()
@click.option(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being removed? I didn't it. Thought we wanted to eliminate "array-job" related stuff.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are the args being passed to the array cli . def array below

@luccabb luccabb merged commit 3fc23d3 into main Oct 6, 2025
17 checks passed
@luccabb luccabb deleted the rm_array branch October 6, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants