Skip to content

always round down #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

always round down #108

wants to merge 2 commits into from

Conversation

luccabb
Copy link
Member

@luccabb luccabb commented Oct 4, 2025 •
edited
Loading

Summary

rounding up has the risk of over-allocating memory/cpus, so always round values down

Test Plan

ci

@luccabb luccabb requested review from skalyan and gunchu as code owners October 4, 2025 00:31
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 4, 2025
@luccabb luccabb changed the title round down always round down Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skalyan skalyan Awaiting requested review from skalyan skalyan is a code owner

@gunchu gunchu Awaiting requested review from gunchu gunchu is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@luccabb