Update README.md according to GraftingConfig merge
#243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D81278578 |
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Aug 28, 2025
…search#243) Summary: `instantiate_preconditioner_config()` only returns `None` when encoutnering `PreconditionerComputationType.None` as input, and this type hint enhancements make the intention more clear. Differential Revision: D81278578
tsunghsienlee
force-pushed
the
export-D81278578
branch
from
7171b47 to
0a333fa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81278578 |
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Aug 28, 2025
…search#243) Summary: `instantiate_preconditioner_config()` only returns `None` when encoutnering `PreconditionerComputationType.None` as input, and this type hint enhancements make the intention more clear. Differential Revision: D81278578
tsunghsienlee
force-pushed
the
export-D81278578
branch
from
0a333fa to
3b210ba
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81278578 |
tsunghsienlee
changed the title
instantiate_preconditioner_config()README.md according to GraftingConfig merge
…rch#243) Summary: Due to facebookresearch#242, `README.md` needs updated accordingly. Differential Revision: D81278578
tsunghsienlee
force-pushed
the
export-D81278578
branch
from
3b210ba to
aac6ba5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81278578 |
wz337
approved these changes
Sep 2, 2025
|
This pull request has been merged in b84794c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Due to #242,
README.mdneeds updated accordingly.Differential Revision: D81278578