Skip to content

chore: flutter upgrade #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: flutter upgrade #2068

wants to merge 1 commit into from

Conversation

asabri97
Copy link

@asabri97 asabri97 commented Apr 9, 2025

No description provided.

@asabri97 asabri97 requested a review from a team as a code owner April 9, 2025 12:03
@codecov
Copy link

codecov bot commented Apr 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.64%. Comparing base (a9e8103) to head (c41180a).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2068      +/-   ##
==========================================
+ Coverage   55.63%   55.64%   +0.01%     
==========================================
  Files         147      147              
  Lines       19159    19168       +9     
==========================================
+ Hits        10659    10666       +7     
- Misses       8500     8502       +2

see 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b4ee0e...c41180a. Read the comment docs.

@asabri97 asabri97 force-pushed the chore/flutter-upgrade branch from 555c5da to 6251c65 Compare April 9, 2025 12:09
@asabri97 asabri97 force-pushed the chore/flutter-upgrade branch 2 times, most recently from cbcae39 to d65bcb2 Compare April 9, 2025 16:18
Yash-Garg
Yash-Garg reviewed Apr 9, 2025
View reviewed changes
Copy link
Contributor

@Yash-Garg Yash-Garg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are only updating the CI flutter version here, is this intentional?

@asabri97
Copy link
Author

asabri97 commented Apr 9, 2025

We are only updating the CI flutter version here, is this intentional?

All the dependencies were already up to date

td-famedly
td-famedly reviewed Apr 10, 2025
View reviewed changes
@asabri97 asabri97 force-pushed the chore/flutter-upgrade branch from d65bcb2 to efd34cb Compare April 10, 2025 12:03
@asabri97 asabri97 force-pushed the chore/flutter-upgrade branch from efd34cb to c41180a Compare April 10, 2025 12:05
krille-chan
krille-chan reviewed Apr 11, 2025
View reviewed changes
lib/src/database/indexeddb_box.dart
@@ -1,3 +1,5 @@
// ignore_for_file: deprecated_member_use
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not sure if it wouldn't be better to directly migrate everything to web. In the SDK actually we don't need to rush for the dart upgrade. Maybe worth another issue I guess? @asabri97

@td-famedly
Copy link
Member

@asabri97 can you take a look at this again please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krille-chan krille-chan krille-chan left review comments

@td-famedly td-famedly Awaiting requested review from td-famedly

@Yash-Garg Yash-Garg Awaiting requested review from Yash-Garg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asabri97 @td-famedly @krille-chan @Yash-Garg