Skip to content

Conversation

asabri97
Copy link

@asabri97 asabri97 requested a review from a team as a code owner May 15, 2025 10:20
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 42.16867% with 48 lines in your changes missing coverage. Please review.

Project coverage is 55.32%. Comparing base (ee51dfc) to head (73ca422).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ib/msc_extensions/msc_1236_widgets/src/widget.dart 20.00% 44 Missing ⚠️
lib/src/event.dart 85.71% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2093      +/-   ##
==========================================
- Coverage   55.33%   55.32%   -0.01%     
==========================================
  Files         146      146              
  Lines       18409    18408       -1     
==========================================
- Hits        10186    10185       -1     
  Misses       8223     8223              
Files with missing lines Coverage Δ
lib/src/event.dart 86.09% <85.71%> (-0.04%) ⬇️
...ib/msc_extensions/msc_1236_widgets/src/widget.dart 20.00% <20.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d8cbfb...73ca422. Read the comment docs.

Copy link
Contributor

@krille-chan krille-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check the other lines where you using as ?? type casts as well? In the best case we would try to avoid them everywhere

getThumbnail ? infoMap['thumbnail_file'] : content['file'];
if (!fileMap['key']['key_ops'].contains('decrypt')) {
final fileMap = getThumbnail
? infoMap['thumbnail_file'] as Map
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of these could probably use the tryGet now right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants