-
Notifications
You must be signed in to change notification settings - Fork 56
refactor: event-getter #2093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: event-getter #2093
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2093 +/- ##
==========================================
- Coverage 55.33% 55.32% -0.01%
==========================================
Files 146 146
Lines 18409 18408 -1
==========================================
- Hits 10186 10185 -1
Misses 8223 8223
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check the other lines where you using as ??
type casts as well? In the best case we would try to avoid them everywhere
0dcec55
to
c1248ea
Compare
c1248ea
to
970421a
Compare
309f1dd
to
86578de
Compare
86578de
to
bca7663
Compare
bca7663
to
918b166
Compare
918b166
to
73ca422
Compare
getThumbnail ? infoMap['thumbnail_file'] : content['file']; | ||
if (!fileMap['key']['key_ops'].contains('decrypt')) { | ||
final fileMap = getThumbnail | ||
? infoMap['thumbnail_file'] as Map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of these could probably use the tryGet now right?
For: https://github.com/famedly/product-management/issues/2210