Skip to content

Conversation

coder-with-a-bushido
Copy link
Contributor

@coder-with-a-bushido coder-with-a-bushido force-pushed the karthi/grp-call-state-stream-refactor branch from 8bc3009 to 890cdf5 Compare September 18, 2025 06:59
@coder-with-a-bushido coder-with-a-bushido force-pushed the karthi/grp-call-state-stream-refactor branch from 890cdf5 to f013e92 Compare September 19, 2025 07:50
@coder-with-a-bushido coder-with-a-bushido changed the title refactor: BREAKING make onGroupCallEvent return actual events type refactor: BREAKING merge onGroupCallState and onGroupCallEvent into matrixRTCEventStream with proper types Sep 19, 2025
@coder-with-a-bushido coder-with-a-bushido force-pushed the karthi/grp-call-state-stream-refactor branch from f013e92 to f1864ed Compare September 19, 2025 07:52
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 68.29268% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.01%. Comparing base (e772d4d) to head (197c247).

Files with missing lines Patch % Lines
lib/src/voip/backend/mesh_backend.dart 62.96% 10 Missing ⚠️
lib/src/voip/models/matrixrtc_call_event.dart 81.81% 2 Missing ⚠️
lib/fake_matrix_api.dart 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2148      +/-   ##
==========================================
+ Coverage   55.44%   57.01%   +1.56%     
==========================================
  Files         148      148              
  Lines       19226    19267      +41     
==========================================
+ Hits        10660    10985     +325     
+ Misses       8566     8282     -284     
Files with missing lines Coverage Δ
lib/src/voip/group_call_session.dart 78.50% <100.00%> (+15.07%) ⬆️
lib/src/voip/utils/types.dart 0.00% <ø> (ø)
lib/fake_matrix_api.dart 64.05% <50.00%> (-0.13%) ⬇️
lib/src/voip/models/matrixrtc_call_event.dart 86.66% <81.81%> (+11.66%) ⬆️
lib/src/voip/backend/mesh_backend.dart 67.57% <62.96%> (+41.05%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e772d4d...197c247. Read the comment docs.

@coder-with-a-bushido coder-with-a-bushido force-pushed the karthi/grp-call-state-stream-refactor branch 2 times, most recently from 97c185b to fa6ee63 Compare October 1, 2025 11:22
@coder-with-a-bushido coder-with-a-bushido force-pushed the karthi/grp-call-state-stream-refactor branch from fa6ee63 to e218b84 Compare October 1, 2025 11:59
@coder-with-a-bushido coder-with-a-bushido changed the title refactor: BREAKING merge onGroupCallState and onGroupCallEvent into matrixRTCEventStream with proper types refactor: merge onGroupCallState and onGroupCallEvent into matrixRTCEventStream with proper types Oct 1, 2025
Copy link
Member

@td-famedly td-famedly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

Copy link
Member

@td-famedly td-famedly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah @coder-with-a-bushido can you also add some tests please?

@coder-with-a-bushido coder-with-a-bushido force-pushed the karthi/grp-call-state-stream-refactor branch from bb8dbbc to 197c247 Compare October 13, 2025 02:15
@coder-with-a-bushido coder-with-a-bushido changed the title refactor: merge onGroupCallState and onGroupCallEvent into matrixRTCEventStream with proper types unify group call stream stuff into matrixRTCEventStream Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants