-
Notifications
You must be signed in to change notification settings - Fork 56
unify group call stream stuff into matrixRTCEventStream #2148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8bc3009
to
890cdf5
Compare
890cdf5
to
f013e92
Compare
f013e92
to
f1864ed
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2148 +/- ##
==========================================
+ Coverage 55.44% 57.01% +1.56%
==========================================
Files 148 148
Lines 19226 19267 +41
==========================================
+ Hits 10660 10985 +325
+ Misses 8566 8282 -284
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
97c185b
to
fa6ee63
Compare
fa6ee63
to
e218b84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah @coder-with-a-bushido can you also add some tests please?
5cf9dc4
to
bb8dbbc
Compare
bb8dbbc
to
197c247
Compare
Closes https://github.com/famedly/product-management/issues/1950