Skip to content

fix: coerce undefined to string (#680) #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: coerce undefined to string (#680) #681

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e61fb2c
fix: coerce undefined to string (#680)
kyleaupton Feb 13, 2024
92fe231
Update lib/serializer.js
kyleaupton Feb 14, 2024
6204045
Merge branch 'master' into fix-issue-680
kyleaupton Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/serializer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ module.exports = class Serializer {

asString (str) {
if (typeof str !== 'string') {
if (str === null) {
if (str == null) {
return '""'
}
if (str instanceof Date) {
Expand Down
28 changes: 28 additions & 0 deletions test/array.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,34 @@ buildTest({
'@data': ['test']
})

test('array of strings with null and undefined elements coerced to empty string', (t) => {
t.plan(1)

const schema = {
type: 'object',
properties: {
foo: {
type: 'array',
items: {
type: 'string'
}
}
}
}

const stringify = build(schema)
const result = stringify({
foo: [
'foo',
'bar',
null,
undefined
]
})

t.equal(result, '{"foo":["foo","bar","",""]}')
})

test('invalid items throw', (t) => {
t.plan(1)
const schema = {
Expand Down