test: migrated start.test.js from tap to node:test #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tony133
force-pushed
the
test/migrated-start-test
branch
from
26eb0da to
baa3f0e
Compare
ilteoood
reviewed
Aug 22, 2025
Contributor
Author
|
In the CI environment, it is unable to skip three tests, very strange 🤔 |
ilteoood
reviewed
Nov 13, 2025
| const semver = require('semver') | ||
| const baseFilename = path.join(__dirname, 'fixtures', `test_${crypto.randomBytes(16).toString('hex')}`) | ||
| const { fork } = require('node:child_process') | ||
| const moduleSupport = semver.satisfies(process.version, '>= 14 || >= 12.17.0 < 13.0.0') |
Contributor
There was a problem hiding this comment.
considering that node >= 20 (the minimum one supported by fastify nowadays) supports module for sure, are we okay with keeping the skip configuration and its tests?
I would probably get rid of those, considering that this value will always be true now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
Proposal:
start.test.jsfromtaptonode:test🔥Note:
Added the
createTestDirfunction to replace.testdir(), becausenode:testdoes not have a method is built-in similar to thetestdir()method oftap.