Add support for image optimization #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgryski
force-pushed
the
dgryski/image-opto
branch
3 times, most recently
from
3180d65 to
9b07972
Compare
cee-dub
approved these changes
Oct 1, 2025
dgryski
force-pushed
the
dgryski/image-opto
branch
from
8d78f80 to
a094f59
Compare
dgryski
force-pushed
the
dgryski/image-opto
branch
from
a094f59 to
246da3c
Compare
|
PTAL. Squashed and ready to merge. Docs copied from the Rust SDK. |
cee-dub
approved these changes
Oct 2, 2025
fsthttp/imageopto/imageopto.go
Outdated
| return nil | ||
| } | ||
|
|
||
| var rePixelsOrPercentage = regexp.MustCompile("^[0-9]+(.[0-9]+)?p?$") |
There was a problem hiding this comment.
Suggested change
| var rePixelsOrPercentage = regexp.MustCompile("^[0-9]+(.[0-9]+)?p?$") | |
| var rePixelsOrPercentage = regexp.MustCompile("^[0-9]+(\.[0-9]+)?p?$") |
ccampbell
reviewed
Oct 7, 2025
| // RequestID is the current Fastly request ID | ||
| RequestID string | ||
|
|
||
| ImageOptimizerOpts *imageopto.Opts |
There was a problem hiding this comment.
Do you think it may make sense to name this ImageOptimizerOptions? I ask because this struct already has CacheOptions and DecompressResponseOptions.
The Rust SDK uses ImageOptimizerOptions, and that was also what it was named in the rough design doc we shared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.