Added 'Locate Device' and 'Save Permanent' functionality #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 5, 2018 16:20
Changed the BlockIdentifier of 'Set' function to temporary Added a second button for 'Save Permanent' functionality Added a new button for 'Locate Device' (See Profinet specs for exact specifications) that let's the device blink until it's told to stop
Changed the BlockIdentifier of 'Set' function to temporary Added a second button for 'Save Permanent' functionality Added a new button for 'Locate Device' (See Profinet specs for exact specifications) that let's the device blink until it's told to stop
# Conflicts: # ProfinetTools.Gui/ViewModels/SettingsViewModel.cs
fbarresi
requested changes
Sep 7, 2018
Owner
fbarresi
left a comment
fbarresi
left a comment
There was a problem hiding this comment.
Thank you for starting this software improvement!
Please make this changes so that I can merge your pull request.
| public ReactiveUI.ReactiveCommand SaveCommand { get; set; } | ||
| public ReactiveUI.ReactiveCommand ResetCommand { get; set; } | ||
|
|
||
| public ReactiveUI.ReactiveCommand SavePermanentCommand { get; set; } |
Owner
There was a problem hiding this comment.
Should we really make two commands for saving settings?
An enum for "Permanent" and "Temporary" would be enough and would avoid code duplication.
| else | ||
| { | ||
| _signalActive = true; | ||
| var newThread = new Thread(new ThreadStart(LocationService)); |
Owner
There was a problem hiding this comment.
Please use Observable.Interval from System.Reactive here instead.
| return Unit.Default; | ||
| } | ||
|
|
||
| private async Task<Unit> SavePermanentDeviceSettings() |
Owner
There was a problem hiding this comment.
Please avoid code duplication here
| raisePropertyChanged(); | ||
| } | ||
| } | ||
| IsDeviceSelected = _selectedDevice != null; |
| <Grid.RowDefinitions> | ||
| <RowDefinition Height="*"/> | ||
| <RowDefinition Height="Auto"/> | ||
| <RowDefinition Height="24.277"/> |
Owner
There was a problem hiding this comment.
Please avoid fix height definition
| } | ||
|
|
||
| public IAsyncResult BeginSetNameRequest(PhysicalAddress destination, string name) | ||
| public IAsyncResult BeginSetNameRequest(PhysicalAddress destination, string name, bool permanent) |
Owner
There was a problem hiding this comment.
This method could expect an enumerable in argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the BlockIdentifier of 'Set' function to temporary
Added a second button for 'Save Permanent' functionality
Added a new button for 'Locate Device' (See Profinet specs for exact specifications) that let's the device blink until it's told to stop