[차세진] Payment 미션 Step1.5 (조금 업데이트..!)

[chasj0326]

구현하면서 어려웠던 점

• useForm 과 useRouter 를 직접 구현해보자! 했는데 이 훅들의 테스트를 구현하는 것이 어려웠습니다 🥲

• Primitive UI 의 개념이 아직 확실히 잡히진 않은 것 같아요..! 자주 사용하는 컴포넌트인 Input 과 Card 를 비슷하게 사용할 수 있도록 구현하였는데, 너무 사용하는 겉모습만 똑같은거 같아서 이게 맞는지 모르겠습니다 허허 ... !! (공부 쫌 더 해보고 수정할 예정이에요)

• useForm 에서, 제네릭으로 폼객체의 타입을 받아서 키를 생성하고 .. 그 키로 폼 상태를 관리하도록 했습니다.

  • 배열의 경우, cardNumbers.1.numbers 라면 cardNumbers 배열의 첫번째 요소의 numbers 값에 대한 키 입니다
  • 타입만을 사용해서 키값을 만드는 연산을 작성해야 했기에 .. 어려웠숩니다

궁금한점 & 리뷰받고싶은 점

기능과 요구사항을 완벽하게 구현한 것이 아니라서 정리가 아직 덜 되었지만 ..! 테스트를 작성하다가 상당히 고민이 되는 부분이 있었어요

Q1

라우팅 기능을 직접 만들었을 때, history 객체에 해당 경로가 잘 올라갔는지를 테스트 하고 싶어요! 이럴때는 어떻게 해야할까요?
(window.history ~~~) 이 친구가 테스트 코드 상에서는 하나도 작동하지 않더라구요 !? 일단 이 부분은 제쳐두고 테스트를 작성했습니다.
따라서 테스트 안에서 직접 컴포넌트를 작성해버린 부분도 있습니다 ㅠㅠ

Q2

contextAPI 를 사용할 때, 각 테스트끼리 상태를 공유하더라구요 ?
혹시 해서 afterEach 문에 clear, resetModule 과 같은 메소드로 초기화를 시도해봤지만 잘 되지 않았습니다.
보통 이렇게 전역 상태 관리나, contextAPI 를 사용할 때는 어떠한 방법으로 테스트 끼리의 독립성을 유지하나요 ? ?

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.