chore: replace micromatch with picomatch

[yslpn]

Improve glob filtering performance by replacing micromatch with picomatch and decrease node_modules size

234kb vs 83kb

https://node-modules.dev/grid/depth#install=picomatch
https://node-modules.dev/grid/depth#install=micromatch

[changeset-bot]

🦋 Changeset detected

Latest commit: 95c6164

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
steiger	Patch
@steiger/integration-tests	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[illright]

I believe the reason why we switched to micromatch instead of picomatch was because of this:

Picomatch does not do brace expansion. For brace expansion and advanced matching with braces, use micromatch instead. Picomatch has very basic support for braces.

— https://github.com/micromatch/picomatch?tab=readme-ov-file#braces

I see the tests are passing with picomatch, which is interesting. I played around a bit with it and it seems like the most interesting use cases of braces (e. g. different extensions like .{test,spec}.{js,ts}) are supported by picomatch. Still, I think it would be a breaking change, so I would hold on with this change until the 0.6 release, which is currently blocked by #197

[illright]

I changed this PRs base to be the next branch, could you please rebase your commits on top of that branch so that we don't have to bother resolving conflicts?

[illright]

Code-wise I think it's great!

[illright]

suggestion (non-blocking): since "positive exclusion" and "negative exclusion" aren't commonly understood terms, hence they require some time to understand, perhaps we could instead have "positive exclusion" and "re-inclusion"?

Suggested change

	const negativeExclusionPatterns =
	const reInclusionPatterns =

[yslpn]

Agree. Fixed

[illright]

Thanks! The regression in the lilconfig migration made me a bit worried, could you add some extra tests to packages/steiger/src/shared/globs/create-filter-according-to-globs.spec.ts relating to brace expansion? Currently there's only one, and it only tests brace expansion in exclusions, I'd like to make sure it also works in inclusions and negated patterns.

[yslpn]

Thanks! The regression in the lilconfig migration made me a bit worried, could you add some extra tests to packages/steiger/src/shared/globs/create-filter-according-to-globs.spec.ts relating to brace expansion? Currently there's only one, and it only tests brace expansion in exclusions, I'd like to make sure it also works in inclusions and negated patterns.

Ok, thanks for the review. I'll add more tests later this week.