feat(steiger-plugin): add no-wildcard-exports rule and fix tsconfig resolution

packages/steiger-plugin-fsd/package.json

@@ -43,6 +43,7 @@
     "@feature-sliced/filesystem": "^3.0.1",
     "fastest-levenshtein": "^1.0.16",
     "lodash-es": "^4.17.21",
+    "oxc-parser": "^0.47.1",
     "pluralize": "^8.0.0",
     "precinct": "^12.2.0",
     "tsconfck": "^3.1.6"

packages/steiger-plugin-fsd/src/index.ts

@@ -10,6 +10,7 @@ import noReservedFolderNames from './no-reserved-folder-names/index.js'
 import noSegmentlessSlices from './no-segmentless-slices/index.js'
 import noSegmentsOnSlicedLayers from './no-segments-on-sliced-layers/index.js'
 import noUiInApp from './no-ui-in-app/index.js'
+import noWildcardExports from './no-wildcard-exports/index.js'
 import publicApi from './public-api/index.js'
 import repetitiveNaming from './repetitive-naming/index.js'
 import segmentsByPurpose from './segments-by-purpose/index.js'
@@ -32,6 +33,7 @@ const enabledRules = [
   noSegmentlessSlices,
   noSegmentsOnSlicedLayers,
   noUiInApp,
+  noWildcardExports,
   publicApi,
   repetitiveNaming,
   segmentsByPurpose,

packages/steiger-plugin-fsd/src/no-wildcard-exports/README.md

@@ -0,0 +1,61 @@
+# `no-wildcard-exports`
+
+Forbid wildcard exports (`export *`) in public APIs of business logic layers. Named exports and namespace exports (`export * as namespace`) are allowed.
+
+**Exception:** Wildcard exports are allowed in unsliced layers (`shared` and `app`), as they serve as foundational layers with different architectural purposes.
+
+This rule treats files named `index.js`, `index.jsx`, `index.ts`, `index.tsx` as the public API of a folder (slice/segment root). Non-index files (including test files like `*.spec.ts`, `*.test.ts`) are ignored.
+
+Examples of exports that pass this rule:
+
+```ts
+// Named exports (business logic layers)
+export { Button } from './Button'
+export { UserCard, UserAvatar } from './components'
+
+// Namespace exports (all layers)
+export * as userModel from './model'
+export * as positions from './tooltip-positions'
+
+// Wildcard exports (unsliced layers: shared, app)
+// shared/ui/index.ts
+export * from './Button'
+export * from './Modal'
+export * from './Input'
+
+// shared/api/index.ts
+export * from './endpoints/auth'
+export * from './endpoints/users'
+
+// app/providers/index.ts
+export * from './AuthProvider'
+export * from './ThemeProvider'
+export * from './RouterProvider'
+```
+
+Examples of exports that fail this rule:
+
+```ts
+// ❌ Wildcard exports in business logic layers
+// entities/user/index.ts
+export * from './model'
+export * from './ui'
+
+// features/auth/index.ts
+export * from './ui'
+export * from './api'
+```
+
+## Rationale
+
+Wildcard exports in business logic layers make it harder to track which exact entities are being exported from a module. This can lead to:
+
+- Unintentionally exposing internal implementation details
+- Difficulty in tracking dependencies between modules
+- Potential naming conflicts when multiple modules use wildcard exports
+
+Using named exports or namespace exports makes the public API more explicit and easier to maintain in business logic layers.
+
+## Autofix
+
+This rule provides a suggested fix for wildcard exports in public API files by replacing them with a named export template (e.g. `export { ComponentA, ComponentB } from './components'`).

packages/steiger-plugin-fsd/src/no-wildcard-exports/index.spec.ts

@@ -0,0 +1,258 @@
+import { expect, it } from 'vitest'
+import { joinFromRoot, parseIntoFolder as parseIntoFsdRoot } from '@steiger/toolkit/test'
+import type { Folder, File } from '@steiger/toolkit'
+
+import noWildcardExports from './index.js'
+
+type FileWithContent = File & { content?: string }
+
+it('reports no errors on a project with valid exports', () => {
+  const root = parseIntoFsdRoot(`
+    📂 shared
+      📂 ui
+        📄 Button.tsx
+        📄 index.ts
+    📂 entities
+      📂 user
+        📂 ui
+          📄 UserCard.tsx
+          📄 index.ts
+        📄 index.ts
+    📂 features
+      📂 auth
+        📂 ui
+          📄 LoginForm.tsx
+          📄 index.ts
+  `)
+
+  function addContentToFiles(folder: Folder): void {
+    for (const child of folder.children) {
+      if (child.type === 'file') {
+        const fileWithContent = child as FileWithContent
+        if (child.path === joinFromRoot('shared', 'ui', 'index.ts')) {
+          fileWithContent.content = "export { Button } from './Button'"
+        } else if (child.path === joinFromRoot('entities', 'user', 'ui', 'index.ts')) {
+          fileWithContent.content = "export { UserCard } from './UserCard'"
+        } else if (child.path === joinFromRoot('entities', 'user', 'index.ts')) {
+          fileWithContent.content = "export * as userModel from './model'"
+        } else if (child.path === joinFromRoot('features', 'auth', 'ui', 'index.ts')) {
+          fileWithContent.content = "export { LoginForm } from './LoginForm'"
+        } else {
+          fileWithContent.content = ''
+        }
+      } else if (child.type === 'folder') {
+        addContentToFiles(child)
+      }
+    }
+  }
+
+  addContentToFiles(root)
+
+  expect(noWildcardExports.check(root)).toEqual({ diagnostics: [] })
+})
+
+it('reports errors on a project with wildcard exports', () => {
+  const root = parseIntoFsdRoot(`
+    📂 shared
+      📂 ui
+        📄 Button.tsx
+        📄 index.ts
+    📂 entities
+      📂 user
+        📂 ui
+          📄 UserCard.tsx
+          📄 index.ts
+        📄 index.ts
+  `)
+
+  function addContentToFiles(folder: Folder): void {
+    for (const child of folder.children) {
+      if (child.type === 'file') {
+        const fileWithContent = child as FileWithContent
+        if (child.path === joinFromRoot('shared', 'ui', 'index.ts')) {
+          fileWithContent.content = "export * from './Button'"
+        } else if (child.path === joinFromRoot('entities', 'user', 'ui', 'index.ts')) {
+          fileWithContent.content = "export * from './UserCard'"
+        } else {
+          fileWithContent.content = ''
+        }
+      } else if (child.type === 'folder') {
+        addContentToFiles(child)
+      }
+    }
+  }
+
+  addContentToFiles(root)
+
+  const diagnostics = noWildcardExports.check(root).diagnostics
+  expect(diagnostics).toEqual([
+    {
+      message: 'Wildcard exports are not allowed in public APIs. Use named exports instead.',
+      location: { path: joinFromRoot('entities', 'user', 'ui', 'index.ts') },
+      fixes: [
+        {
+          type: 'modify-file',
+          path: joinFromRoot('entities', 'user', 'ui', 'index.ts'),
+          content: '// Replace with named exports\n// Example: export { ComponentA, ComponentB } from "./components"',
+        },
+      ],
+    },
+  ])
+})
+
+it('allows export * as namespace pattern', () => {
+  const root = parseIntoFsdRoot(`
+    📂 shared
+      📂 ui
+        📄 positions.ts
+        📄 index.ts
+    📂 entities
+      📂 user
+        📄 model.ts
+        📄 index.ts
+  `)
+
+  function addContentToFiles(folder: Folder): void {
+    for (const child of folder.children) {
+      if (child.type === 'file') {
+        const fileWithContent = child as FileWithContent
+        if (child.path === joinFromRoot('shared', 'ui', 'index.ts')) {
+          fileWithContent.content = "export * as positions from './positions'"
+        } else if (child.path === joinFromRoot('entities', 'user', 'index.ts')) {
+          fileWithContent.content = "export * as userModel from './model'"
+        } else {
+          fileWithContent.content = ''
+        }
+      } else if (child.type === 'folder') {
+        addContentToFiles(child)
+      }
+    }
+  }
+
+  addContentToFiles(root)
+
+  expect(noWildcardExports.check(root)).toEqual({ diagnostics: [] })
+})
+
+it('ignores wildcard exports in non-public files', () => {
+  const root = parseIntoFsdRoot(`
+    📂 shared
+      📂 ui
+        📄 internal.ts
+        📄 index.ts
+    📂 entities
+      📂 user
+        📂 ui
+          📄 internal-utils.ts
+          📄 index.ts
+  `)
+
+  function addContentToFiles(folder: Folder): void {
+    for (const child of folder.children) {
+      if (child.type === 'file') {
+        const fileWithContent = child as FileWithContent
+        if (child.path.endsWith('internal.ts')) {
+          fileWithContent.content = "export * from './components'"
+        } else if (child.path.endsWith('internal-utils.ts')) {
+          fileWithContent.content = "export * from './utils'"
+        } else {
+          fileWithContent.content = ''
+        }
+      } else if (child.type === 'folder') {
+        addContentToFiles(child)
+      }
+    }
+  }
+
+  addContentToFiles(root)
+
+  expect(noWildcardExports.check(root)).toEqual({ diagnostics: [] })
+})
+
+it('ignores wildcard exports in test files', () => {
+  const root = parseIntoFsdRoot(`
+    📂 shared
+      📂 ui
+        📄 Button.test.ts
+        📄 index.ts
+    📂 entities
+      📂 user
+        📂 ui
+          📄 UserCard.spec.ts
+          📄 index.ts
+  `)
+
+  function addContentToFiles(folder: Folder): void {
+    for (const child of folder.children) {
+      if (child.type === 'file') {
+        const fileWithContent = child as FileWithContent
+        if (child.path.endsWith('Button.test.ts')) {
+          fileWithContent.content = "export * from './test-utils'"
+        } else if (child.path.endsWith('UserCard.spec.ts')) {
+          fileWithContent.content = "export * from './test-utils'"
+        } else {
+          fileWithContent.content = ''
+        }
+      } else if (child.type === 'folder') {
+        addContentToFiles(child)
+      }
+    }
+  }
+
+  addContentToFiles(root)
+
+  expect(noWildcardExports.check(root)).toEqual({ diagnostics: [] })
+})
+
+it('allows wildcard exports in unsliced layers (shared and app)', () => {
+  const root = parseIntoFsdRoot(`
+    📂 shared
+      📂 ui
+        📄 Button.tsx
+        📄 Modal.tsx
+        📄 index.ts
+      📂 api
+        📄 client.ts
+        📄 endpoints.ts
+        📄 index.ts
+    📂 app
+      📂 providers
+        📄 AuthProvider.tsx
+        📄 ThemeProvider.tsx
+        📄 index.ts
+      📂 routes
+        📄 index.ts
+    📂 entities
+      📂 user
+        📂 ui
+          📄 UserCard.tsx
+          📄 index.ts
+  `)
+
+  function addContentToFiles(folder: Folder): void {
+    for (const child of folder.children) {
+      if (child.type === 'file') {
+        const fileWithContent = child as FileWithContent
+        if (child.path === joinFromRoot('shared', 'ui', 'index.ts')) {
+          fileWithContent.content = "export * from './Button'\nexport * from './Modal'"
+        } else if (child.path === joinFromRoot('shared', 'api', 'index.ts')) {
+          fileWithContent.content = "export * from './client'\nexport * from './endpoints'"
+        } else if (child.path === joinFromRoot('app', 'providers', 'index.ts')) {
+          fileWithContent.content = "export * from './AuthProvider'\nexport * from './ThemeProvider'"
+        } else if (child.path === joinFromRoot('app', 'routes', 'index.ts')) {
+          fileWithContent.content = "export * from './home'\nexport * from './auth'"
+        } else if (child.path === joinFromRoot('entities', 'user', 'ui', 'index.ts')) {
+          fileWithContent.content = "export { UserCard } from './UserCard'"
+        } else {
+          fileWithContent.content = ''
+        }
+      } else if (child.type === 'folder') {
+        addContentToFiles(child)
+      }
+    }
+  }
+
+  addContentToFiles(root)
+
+  expect(noWildcardExports.check(root)).toEqual({ diagnostics: [] })
+})