Skip to content

Changes to upgrade to v5 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sclebal wants to merge 44 commits into
base: felt/disable-backdrop-animation
Choose a base branch
from
Open

Changes to upgrade to v5 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
c9964a6
wip
sclebal Sep 26, 2025
fb6e85c
correctly check disableScroll
sclebal Oct 3, 2025
62f6f50
recompute scrollPosition on scroller resize
sclebal Oct 3, 2025
9e375dd
Add optional bounce
sclebal Oct 3, 2025
5185421
Sign pushes
sclebal Oct 7, 2025
8a6223f
React to element changes on use-resize-observer and use-scroll-position
sclebal Oct 8, 2025
c3c24cf
handle quick close and open more gracefully
sclebal Oct 15, 2025
c1bee29
keyboard improvements
sclebal Oct 10, 2025
5be1ff1
stop ongoing animation when closing
sclebal Oct 15, 2025
4933955
Use virtual keyboard api when possible to detect keyboard height
sclebal Oct 18, 2025
fb4c932
Stop using env var keyboard-inset-height
sclebal Nov 11, 2025
135996e
mock ref
sclebal Nov 13, 2025
9d8878d
avoid sheet dimension change when overflowing
sclebal Nov 15, 2025
3c14ca7
use clip to avoid sheet root to scroll programmatically
sclebal Nov 17, 2025
002cb74
better safe area inset management
sclebal Nov 18, 2025
01b101a
adjust sheet y if current snap changes
sclebal Nov 18, 2025
599a751
export useSafeAreaInsets
sclebal Nov 18, 2025
2828257
better keyboard avoidance
sclebal Nov 19, 2025
2a43b45
make sheet to full screen when opening keyboard instant
sclebal Nov 19, 2025
0f1cf96
fix safeToRemove not working inside onCloseEnd
sclebal Nov 19, 2025
584b429
reuse safe area detector between sheets
sclebal Nov 19, 2025
4e66e64
correctly type snapTo with immediate option
sclebal Nov 19, 2025
bfc3f27
do not remove safe area detector, it might be used by someone else
sclebal Nov 19, 2025
dacecf6
fix closable sheet with default detent not fully closing
sclebal Nov 20, 2025
23f5b75
add skipOpenAnimation so the sheet opens as soon as possible
sclebal Nov 20, 2025
9fb7cf7
handle sheet opening and closing so race conditions are unlikely
sclebal Nov 21, 2025
db03c95
Disable backdrop userSelect on WebKit
sclebal Nov 21, 2025
8ff8ea0
earlier insets computing
sclebal Nov 24, 2025
195fe2a
correctly handle changing sheet y while it's opening
sclebal Nov 26, 2025
30e42f7
Keep focused inputs on the view when opening keyboard
sclebal Dec 8, 2025
b1e6a51
Extract position logic from Container into its own component and intr…
sclebal Dec 8, 2025
68cb76c
Animate react-modal-sheet-above enter and exit
sclebal Dec 9, 2025
a751cb3
Better usage of positioner and container refs
sclebal Dec 10, 2025
61f6ef2
Add disableClose property. Handle close on escape.
sclebal Dec 10, 2025
aaba185
better opening and closing
sclebal Dec 10, 2025
0f797df
add support for disabling closing sheet on escape
sclebal Dec 10, 2025
c63c83e
remove console.log
sclebal Dec 11, 2025
f68adde
remove disableClose
sclebal Dec 11, 2025
be50e15
Fix issue with scrolling to focused element when focus changes progra…
tomhicks Dec 15, 2025
5389555
Prevent hitting input when scrolling
sclebal Dec 15, 2025
8bc85e9
Ensure sheet content height is constrained
tomhicks Dec 22, 2025
1e6190f
Extract utility isTextInput. Extract useSnapOnFocus for clarity and i…
sclebal Dec 18, 2025
bd28f97
introduce content-fixed: sheet height doesnt change after initial render
sclebal Dec 30, 2025
b82fb79
rename content-fixed to initial-content
sclebal Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
231 changes: 230 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"link": "yalc publish && npm run link:example && npm run link:example-ssr",
"link:example": "cd example && yalc add react-modal-sheet && npm i",
"link:example-ssr": "cd example-ssr && yalc add react-modal-sheet && npm i",
"link:update": "tsup --dts-only && yalc push --replace",
"link:update": "tsup --dts-only && yalc push --sig --replace",
"test": "vitest run",
"typecheck": "tsc --noEmit",
"verify": "run-p format:check lint:check typecheck",
Expand All @@ -70,7 +70,8 @@
"tsup": "8.4.0",
"typescript": "5.8.3",
"vite": "6.3.3",
"vitest": "3.1.2"
"vitest": "3.1.2",
"yalc": "1.0.0-pre.53"
},
"engines": {
"node": ">=18"
Expand Down
Loading