Skip to content

add descriptions for readme config fields in generators.yml reference #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025

Conversation

tstanmay13
Copy link
Contributor

We had some questions about readme generation so updating these values so customers know what each field is.

@tstanmay13 tstanmay13 requested a review from devalog July 28, 2025 23:22
Copy link
Contributor

Copy link
Contributor

promptless bot commented Jul 28, 2025

✅ No documentation updates required.

@@ -402,30 +402,39 @@ readme:
```

<ParamField path="readme" type="ReadmeSchema" required={false} toc={true}>
Configuration for customizing the generated README files.
</ParamField>

<ParamField path="readme.bannerLink" type="string" required={false} toc={true}>
Copy link
Collaborator

@devalog devalog Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all of these, could you take out the "readme."? It's a bit more user friendly. (Context: I'm the one who structured it this way in the first place😬, but I'm slowly going through and trying to improve this page section by section.)

example: path="readme.bannerLink" --> path="bannerLink"

</ParamField>

<ParamField path="readme.apiReferenceLink" type="string" required={false} toc={true}>
URL to your external API documentation or reference guide.
</ParamField>

<ParamField path="readme.defaultEndpoint" type="ReadmeEndpointSchema" required={false} toc={true}>
Copy link
Collaborator

@devalog devalog Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can make defaultEndpoint a new subsection

### defaultEndpoint
Specifies which endpoint's code snippet to showcase as the primary example in the README.

<ParamField path="method" type="string" required={true} toc={true}>
  HTTP method of the default endpoint (e.g., `GET`, `POST`, `PUT`, `DELETE`).
</ParamField>

etc

Context: I'm trying to do something similar in this outstanding PR: #175

@@ -402,30 +402,39 @@ readme:
```

<ParamField path="readme" type="ReadmeSchema" required={false} toc={true}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since readme is the top-level option, I think you can actually remove the ParamField formatting and move the description up above the yaml code block. (Might need to do some wordsmithing to merge it with the existing description.)

</ParamField>

<ParamField path="readme.defaultEndpoint.stream" type="boolean" required={false} toc={true}>
Whether the endpoint is a streaming endpoint. Defaults to `false`.
</ParamField>

<ParamField path="readme.features" type="map<string, list<ReadmeEndpointSchema>>" required={false} toc={true}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have the time, I think it would be great to have features as another subsection and then separate ParamFields for each feature name ie authentication, users, and their subfields.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also feel free to skip this, definitely ok to merge your changes without adding this info!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good I will pick up this as an item for later then!

Copy link
Contributor

@tstanmay13 tstanmay13 merged commit 164c786 into main Jul 29, 2025
1 check passed
@tstanmay13 tstanmay13 deleted the tanmay/update-readme-in-generators-ref branch July 29, 2025 14:48
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants