Skip to content

Conversation

ReCore-sys
Copy link
Collaborator

@ReCore-sys ReCore-sys commented Aug 17, 2025

Inventories are a part of minecraft. We are implementing minecraft. It's fairly simple.

Description

This PR adds support for inventories as well as placing (some) blocks correctly, based on what you are holding. While not super useful on it own, it is extremely useful for other stuff. This is a somewhat minimal implementation however, since item components hasn't been implemented, though we currently don't have anything like anvils or enchantments so this isn't an issue for now. Additionally the block placing is fairly rudimentary and can't handle stuff like blocks being placed facing certain ways or items not having the same name as the block they place.

This PR does also fix a bug relating to favicons added in #206

Motivation and Context

Having inventories is vital for both building general gameplay.

How has this been tested?

Unit tests and in game testing

Screenshots (if appropriate):

xMQMfA0.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (restructuring code, without changing its behavior)

Checklist:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Clippy passes with no warnings.

@ReCore-sys ReCore-sys marked this pull request as ready for review September 13, 2025 16:21
@ReCore-sys ReCore-sys merged commit 60ac95d into master Sep 13, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in FerrumC's beloved project Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant