-
-
Notifications
You must be signed in to change notification settings - Fork 65
Inventories #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Inventories #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inventories are a part of minecraft. We are implementing minecraft. It's fairly simple.
Description
This PR adds support for inventories as well as placing (some) blocks correctly, based on what you are holding. While not super useful on it own, it is extremely useful for other stuff. This is a somewhat minimal implementation however, since item components hasn't been implemented, though we currently don't have anything like anvils or enchantments so this isn't an issue for now. Additionally the block placing is fairly rudimentary and can't handle stuff like blocks being placed facing certain ways or items not having the same name as the block they place.
This PR does also fix a bug relating to favicons added in #206
Motivation and Context
Having inventories is vital for both building general gameplay.
How has this been tested?
Unit tests and in game testing
Screenshots (if appropriate):
xMQMfA0.mp4
Types of changes
Checklist: