Add pagination to ClusterTaskHistory #617
Merged
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LexLuthr
requested changes
Sep 4, 2025
There was a problem hiding this comment.
If we are adding pagination then it must be added correctly and propagated from UI.
https://github.com/filecoin-project/curio/blob/main/web/static/pages/mk12-deals/mk12-deals.mjs
No need to override from GO side.
|
Updated - for the overview page, I've set a default limit of 20 instead of implementing full pagination UI, as extensive pagination isn't needed here. |
LexLuthr
approved these changes
Sep 4, 2025
magik6k
approved these changes
Sep 11, 2025
rvagg
pushed a commit
that referenced
this pull request
Sep 12, 2025
* Add pagination to cluster task history * Remove task history limit/offset defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pagination support to the
ClusterTaskHistoryRPC method by addinglimitandoffsetparameters.Changes:
limitandoffsetparameters toClusterTaskHistory()method[0, 0]to maintain previous default behaviorFrontend passes
[0, 0]to preserve the original behavior where limit defaulted tolen(taskSPIDs)and offset was 0.