-
Notifications
You must be signed in to change notification settings - Fork 72
ci: create release workflow that uses cargo release #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
09fbfcb
edafc57
b2618e2
287460c
d008963
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,42 @@ | ||||||
name: Release | ||||||
|
||||||
on: | ||||||
workflow_dispatch: | ||||||
inputs: | ||||||
level: | ||||||
description: 'Release level' | ||||||
required: true | ||||||
default: 'patch' | ||||||
type: choice | ||||||
options: | ||||||
- patch | ||||||
- minor | ||||||
- major | ||||||
|
||||||
defaults: | ||||||
run: | ||||||
shell: bash | ||||||
|
||||||
jobs: | ||||||
release: | ||||||
runs-on: ubuntu-latest | ||||||
# The permissions should allow the user to: | ||||||
# 1. Push to the branch of the repository that triggered the workflow. | ||||||
# 2. Create a tag. | ||||||
# 3. Push to crates.io. | ||||||
permissions: | ||||||
contents: write | ||||||
steps: | ||||||
- uses: actions/checkout@v4 | ||||||
- name: Install required packages | ||||||
run: sudo apt install --no-install-recommends --yes libhwloc-dev nvidia-cuda-toolkit ocl-icd-opencl-dev | ||||||
- name: Install cargo release | ||||||
run: cargo install --version 0.25.17 cargo-release | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] The cargo-release version is pinned to a specific version (0.25.17). Consider using a more recent version or document why this specific version is required, as newer versions may contain bug fixes and improvements.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
- name: Set git user | ||||||
run: | | ||||||
git config --global user.email "${GITHUB_TRIGGERING_ACTOR}@users.noreply.github.com>" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is an extra closing angle bracket '>' at the end of the email address. It should be '${GITHUB_TRIGGERING_ACTOR}@users.noreply.github.com' without the trailing '>'.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
git config --global user.name "${GITHUB_TRIGGERING_ACTOR}" | ||||||
- name: Run cargo release | ||||||
env: | ||||||
CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
I debated about the name here, but I thought best to make this an organizational token at which point |
||||||
run: cargo release ${{ github.event.inputs.level }} --no-confirm --execute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing packages with sudo without specifying versions could introduce security risks. Consider pinning package versions or using a container image with pre-installed dependencies for more reproducible and secure builds.
Copilot uses AI. Check for mistakes.