Add common_google_play_services_unknown_issue to keep.xml

[pswaminathan]

Otherwise this can get stripped out by the resource shrinker. The issue here arises when running Firebase on a device without Google Play services. Without this, an app having undergone resource shrinking will crash being unable to find this resource. Because some Firebase services are documented to work without Play services, this shouldn't cause a crash.

[gemini-code-assist]

Summary of Changes

Hello @pswaminathan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where Firebase applications could crash on devices without Google Play services due to resource shrinking. By explicitly adding the common_google_play_services_unknown_issue string to the keep.xml file, the change ensures this essential resource is not removed, thereby preventing crashes and maintaining compatibility for Firebase services on a wider range of Android devices.

Highlights

• Resource Shrinking Fix: Ensures the common_google_play_services_unknown_issue string resource is preserved during resource shrinking.
• Firebase Compatibility: Addresses a crash scenario for Firebase applications running on devices without Google Play services, aligning with Firebase's documented ability to function in such environments.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request correctly adds the common_google_play_services_unknown_issue string to firebase_common_keep.xml. This is an important fix to prevent crashes on devices without Google Play services when resource shrinking is enabled. I have one suggestion to improve the readability of the XML file.

[gemini-code-assist]

For better readability and maintainability, consider splitting the long list of resources in the tools:keep attribute into multiple lines. This makes it easier to see all the kept resources at a glance and to manage them in the future.

    tools:keep="@string/google_app_id,
                @string/gcm_defaultSenderId,
                @string/google_api_key,
                @string/firebase_database_url,
                @string/ga_trackingId,
                @string/google_storage_bucket,
                @string/project_id,
                @string/common_google_play_services_unknown_issue" />