Remove deprecated Auth function from C++ SDK #1767
Closed
+1
−227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matching a change made in the Unity SDK, this commit removes: - Auth: `User::UpdateEmail` and `User::UpdateEmailLastResult` Updated the release notes to reflect this change.
jonsimantov
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
❌ Integration test FAILEDRequested by @jonsimantov on commit 76cf4a7
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Matching a change made in the Unity SDK, this commit removes: - Auth: `User::UpdateEmail` and `User::UpdateEmailLastResult` methods. Integration tests in `ta/auth/it/src/integration_test.cc` were updated: - Removed a call to `UpdateEmail` on an invalid user. - Commented out calls to `UpdateEmail` in `TestUpdateEmailAndPassword` to allow build to pass. Further work is needed to update this test to the new email verification flow. Updated the release notes to reflect this change.
jonsimantov
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
a-maurice
reviewed
Jul 7, 2025
| @@ -767,16 +762,16 @@ TEST_F(FirebaseAuthTest, TestUpdateEmailAndPassword) { | |||
| EXPECT_TRUE(user.is_valid()); | |||
|
|
|||
| // Update the user's email and password. | |||
| const std::string new_email = "new_" + email; | |||
| WaitForCompletion(user.UpdateEmail(new_email.c_str()), "UpdateEmail"); | |||
| // const std::string new_email = "new_" + email; | |||
There was a problem hiding this comment.
Remove instead of commenting out
Matching a change made in the Unity SDK, this commit removes: - Auth: `User::UpdateEmail` and `User::UpdateEmailLastResult` methods. Integration tests in `ta/auth/it/src/integration_test.cc` were updated: - Removed a call to `UpdateEmail` on an invalid user. - Removed commented-out calls to `UpdateEmail` in `TestUpdateEmailAndPassword`. Updated the release notes to reflect this change.
jonsimantov
commented
Jul 11, 2025
| // const std::string new_email = "new_" + email; | ||
| // WaitForCompletion(user.UpdateEmail(new_email.c_str()), "UpdateEmail"); | ||
| // Update the user's password. | ||
| // Email update functionality has been changed and the old UpdateEmail method removed. |
There was a problem hiding this comment.
Just remove this second part completely.
… all tests. To match a change made in the Unity SDK, I will remove: - Auth: `User::UpdateEmail` and `User::UpdateEmailLastResult` methods. I will also remove all usages of the deprecated method from the integration tests (`auth/integration_test/src/integration_test.cc`) and unit tests (`auth/tests/user_test.cc` and `auth/tests/desktop/user_desktop_test.cc`). I will then update the release notes to reflect this change.
… all associated tests. To align with a recent change in the Unity SDK, I will remove the `User::UpdateEmail` and `User::UpdateEmailLastResult` methods from the authentication functionality. This will also involve removing all uses of the deprecated method from the integration and unit tests. Finally, I will update the release notes to reflect this change.
jonsimantov
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This commit removes the deprecated `User::UpdateEmail` method from the Auth SDK, integration tests, unit tests, and sample code. BREAKING CHANGE: `User::UpdateEmail` has been removed. Use `User::SendEmailVerificationBeforeUpdatingEmail` instead.
auto-merge was automatically disabled
July 14, 2025 20:08
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Matching a change made in the Unity SDK, this commit removes:
User::UpdateEmailandUser::UpdateEmailLastResultUpdated the release notes to reflect this change.
Testing
Integration tests.
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.